apache / dubbo

The java implementation of Apache Dubbo. An RPC and microservice framework.

https://dubbo.apache.org/

Apache License 2.0

40.47k stars 26.43k forks source link

QOS Ready command return OK when DubboBootstrap is not ready #7332

Closed nickwongwong closed 3 years ago

nickwongwong commented 3 years ago

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 2.7.8
Operating System version: MacOS
Java version: 8
Service register: nacos
spring-cloud-starter-dubbo 2.2.2.RELEASE

Steps to reproduce this issue

Change dubbo register server into a bad address(like incorrect port)
Start dubbo application
Check QOS ready command, return true(as OK). curl "localhost:22222/ready"。

Expected Result

QOS ready command return "false", when DubboBootstrap is not ready or start failed.

Actual Result

return "true" as OK

relative PR

5873

nickwongwong commented 3 years ago

This command is very useful to check application is ready to visit when booting.

AlbumenJ commented 3 years ago

close #7332 via #7333

horizonzy commented 3 years ago

Hi, I can't reply your mail, you can communite with my wechat zhao1995yan.