fix(tooltip): fix potential NPE when setting option with `notMerge` strategy

apache / echarts

Apache ECharts is a powerful, interactive charting and data visualization library for browser

https://echarts.apache.org

Apache License 2.0

60.69k stars 19.62k forks source link

fix(tooltip): fix potential NPE when setting option with `notMerge` strategy #20435

Closed ktx-abhay closed 1 month ago

ktx-abhay commented 1 month ago

Fix #20335
Optional chaining for tooltip offsetWidth and offsetHeight

Brief Information

This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?

Fixed issues

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

[x] This PR doesn't relate to document changes
[ ] The document should be updated later
[ ] The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

[x] Please squash the commits into a single one when merging.

Other information

echarts-bot[bot] commented 1 month ago

Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

github-actions[bot] commented 1 month ago

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20435@50b715b

Ovilia commented 1 month ago

We sincerely appreciate your valuable contributions! We are currently running a special promotion for users who submit a Pull Request between September 25, 2024, and December 31, 2024. Eligible participants will receive a two-year enterprise membership to Baidu Comate (Please note that in order to register Comate, you need to have a phone number in China due to local regulations), valued at 2000 RMB (approximately 285 USD).

To learn more about this product, please visit https://comate.baidu.com/. If you are interested in this offer, kindly send an email with the link to your Pull Request along with your Comate username and email address to ovilia@apache.org to claim your membership.

Thank you once again for your support!

echarts-bot[bot] commented 1 month ago

Congratulations! Your PR has been merged. Thanks for your contribution! 👍