Open A0nameless0man opened 2 weeks ago
Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.
Support blur
and emphasis
status for labelLayout
.
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20476@931326a
There is only one test label-layout
has diff except those ut i added. Not sure why.
Initial state is same.
And test candlestick-large2
failed because of timeout, likely due to my weak computer and/or wsl overhead.
Brief Information
This pull request is in the type of:
What does this PR do?
Make sure
labelLayout
is enforced to all four state of label.Fixed issues
labelLayout
option ignored in blur state for sunburst chart.Example
Details
Before: What was the problem?
Current impl of sunburst chart calculates label position in SunburstPiece.ts, and apply it to all display state. However, this impl didn't take
labelLayout
into account and causes conflict aslabelLayout
is only applied to normal state for now.This inconsistency causes strange animation on mouse hover.
After: How does it behave after the fixing?
Now with this pr,
labelLayout
always takes priority.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information
As an inexperienced front-end developer, this PR may require more reviews to avoid breaking any existing use cases. Also, I am currently unable to add unit tests for this PR, which may require further processing.