apache / echarts

Apache ECharts is a powerful, interactive charting and data visualization library for browser
https://echarts.apache.org
Apache License 2.0
60.69k stars 19.62k forks source link

[Bug] Markline symbolOffset array value does not work #20483

Closed janvorwerk closed 6 days ago

janvorwerk commented 2 weeks ago

Version

5.5.1

Link to Minimal Reproduction

https://echarts.apache.org/examples/en/editor.html?code=PYBwLglsB2AEC8sDeAoWsAeBBDEDOAXMmurGAJ4gCmRA5JALZW0A0J6ARlQOYTR0AmAAwCALAFoAjEPFDJrdrCrQAJoJETpsgOy0SAXzbpyOfEVSkylGrFoA3AIYAbAK7MDR2HioAnCFUJYAG1FC0tYFQcwByIQ8NIg2mExKRk5VlhJAFYhAF1PeMTkzTSBDIEAZjyC8KKNVNkK8rF8xUs6lK0hUXLJAA5W-PQOktksjMkKrMGhkYahADYJ0W0ZwqT6rt0WWAEFvLbYNdIKajonPmYa9AYHHwBrABlL80P0PHIGDmAnWLfSWjQGBXf7oWggKIACwIAHoYQBZWALFiSWBYTIAOiE2MkKKxONgQkJxKyLAEsAAarAKrAABKwUQYrKwADC1IxokkC25fRYNIEHO0Cz6AE5JNo-RzRAIBFkFjTJBi-kKRVkKrjGZJxf1tMzFQJtNo5KJSYztCKBFrlZkWFkMQssgbtNbcQsmTbtBiKisZZNMU7jaS-hjhM6-n7FcqFqr1Sxg30-gJw7LdoLhWKJSKmVlDaIKtp2ZzucKUUTGaTpHTYHbhOqU2y7VlHQ7JKIUQKKsJugskRjVfK-tyUYy9iLuiLYCKUTWc-GaVTxazJyi3SK-kIqjT4yLdYbceKMVyxUIC8GFlrO-GUZ6qifw7BPbKKsKK56LaOaW6sq2ssqUVn82xLIJzdMRLWVUlLSrURYAcG1USJRDYCkFF4OJJD91gSFqUyIkaTgzCkKJXEpDQojkJI1FsPEAUwP6PpYAAY2QoQQ20SoRSnKR7QETjOQorEtVEHcWHECosUNKoCxor1o1bUTxOjC1JAnajWOxck2WyQ8REdV9Dzk89MgrVd12fPVX0pYyQ1nP0tM9bpn0mYcQ2jcdMmDUQVm9KdJA7LtRB7foMXNYVdVLKsVPdNlhCZPoKgSgQIstJlKmkXksybXN812AU_KqFY4yVRNk2ZGUQplNcgxDO8512CoWBvH1LX5Bqv3q217UdQ1rXK9jeL6U0QuUnVcsPSpuglTVtQg3ZFUddUhF5cSvJlOV-VY38Es7PlMky3b6RUqzyXRRVsTkPFzoQ9CPNQgAtWAGBtclsMrOxMmrJjCTJELtE7YVkNovY_rbZlxFJZk2SzGUFj-qZhwfFFFUkvYGMzKyYIexFy1tKtmSpBj6XLJdxLFYtDTjdl9gWLzukapVxVlNV2XzAro3pptAtm8TJhFB1vXp3jLRUgs2r7ERDV1akWHasWhB3GUUx5io-bVUGQtqjcWb-7spztLy1T85lFMWWn1f6A0vNFvsuW5CnmRx5ksb23HsM2r7NvixKWEQpURSmZFWIt7QrcxPzozVH2pUN-tdlYwcN0Ku0jTDLXLRlrEFbWuaM7K11xadKXYoT70JUfEadzjniI4az1ObCsrWJVgP6fDdimw2rEvZ2hioqDSKJ2drVp2Ghuly1L1RCEb9fLtPpRDboLFRpuUlpXTIkq5D2vSyPMLR9wkupFBeSKD79Exg0-arrfHMgLZihDxLU-b5w_4tFee8XNJat_m7qBbyipVsqICL4gumdAk5F1IiAPlpO0J5HT7yilMP68VrI5G0FyJKsVpAiHlNZXUv5gJklRPSYMYhORTx7A_EMC9ozOlEvHTif0CysWFNPWGyJuI0z2IufUchtRcUjOuQaE5QFXUupAm60CVKkiJFpIO545DImCt_cMS8UTBmftGDRi47p6CGEca4pAPhfB-AAZQgAALxsFyYx7xPjfCcAAeQAGauO8GAWI4NH7VmqLAOEsB8B4DcEEvAWFfA2B8WEoJ3AgQ-CoCof4TgHBcF-MgLwkJgAAHciCuOcN4WAhh_iRGiH8Qx6AwgVMwKYQIGxOhpB6KCIp_xciHH0IoDp6A2n6AANxAA

Steps to Reproduce

The reproduction link demonstrates the issue: the X and Y offset of the symbol cannot be changed independently.

Current Behavior

It seems that the symbolOffset[0] is ignored and symbolOffset[1] is applied for both X & Y offsets

Expected Behavior

symbolOffset[0] should specify the X offset and symbolOffset[1] the Y offset

Environment

- OS: macOS Sonoma 14.6.1
- Browser: Chrome 130
- Framework: Vanilla JS in the repro test case

Any additional comments?

No response

plainheart commented 2 weeks ago

MarkLine has two symbols so its symbolOffset should be a 2D array. See this demo.

janvorwerk commented 1 week ago

@plainheart, thanks a lot! Indeed, this is logical and it works! Apologies for raising this bug.

I still can see two issues:

  1. the doc is incomplete (actually there doesn't seem to be an entry for series[line]>markLine>symbolOffset at all
  2. the Typescript typings do not support this 2x2 D array

I leave it to you to re-open this issue (or file another one) if you think that these should be fixed.

plainheart commented 1 week ago

Thanks for your feedback. I think the documentation and typings should be updated.