apache / echarts

Apache ECharts is a powerful, interactive charting and data visualization library for browser
https://echarts.apache.org
Apache License 2.0
60.71k stars 19.62k forks source link

test(aria): fix test case of #20218 #20484

Closed Ovilia closed 7 hours ago

Ovilia commented 2 weeks ago

Brief Information

This pull request is in the type of:

What does this PR do?

Fix the doc of #20218.

Fixed issues

Details

Before: What was the problem?

It should be aria.label.data.excludeDimensionId instead of aria.data.excludeDimensionId. The old test case can pass but it's because it inherited from the parent.

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

Misc

ZRender Changes

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

Other information

echarts-bot[bot] commented 2 weeks ago

Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

github-actions[bot] commented 2 weeks ago

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20484@3cb583f

echarts-bot[bot] commented 7 hours ago

Congratulations! Your PR has been merged. Thanks for your contribution! 👍