Axis-triggered tooltip failed to display some series if x axis values are not 100% equal!

buhichan commented 5 years ago

[x] I am using English in this issue. 在这个 Issue 中我使用了英文（强烈建议）。

General Questions

[x] Required: I have read the document and examples and tried to solve it by myself. （必填）我读过了文档和教程，并且曾试图自己解决问题。
[x] Required: I have searched for similar issues and that didn't help. （必填）我搜索过 issue 但是没有帮助。
[x] Required: I have tried with the latest version of ECharts and still have this problem. （必填）我试过最新版本的 ECharts，还是存在这个问题。

In this issue, I have provided information with: 在这个 issue 中我提供了以下信息：

[x] Required: issue type；（必填）issue 类型
[x] Required: one sentence description in issue details；（必填）一句话的问题描述
[x] Required: demo；（必填）能反映问题的例子（如果你想提问或报 bug）
[x] Required: ECharts version；ECharts 版本

Issue Type

[ ] I have a question to ask about how to use ECharts to ...；我想提问如何使用 ECharts 实现某功能
[x] I have a bug to report；我想要报 bug
[ ] I have a feature to request, e.g.: I'd like a new feature that ...；我需要一个新功能
[x] I have a feature to enhance, e.g.: The current feature should be improved in the way that ...；我希望改进某个功能
[ ] There's something wrong with the documents；文档有些问题
[ ] Others, or I'm not sure which issue types to choose here；其他，或我不知道应该选什么类型

Issue Details

Axis-triggered tooltip failed to display some series if x axis values are not 100% equal!

Expected Behavior

Axis-triggered should always show the nearest data index of all series, like this:

series1: 5
series2: 5

Current Behavior

It always shows one of the series, but never both.

Online Example

http://jsfiddle.net/sh1acjqu/3/

This is my chart options:

{
            title: {
                text: 'ECharts 入门示例'
            },
            tooltip: {
                trigger: "axis"
            },
            legend: {
                data:['销量']
            },
            xAxis: {
                type: "time"
            },
            yAxis: {},
            series: [{
                name: 'series1',
                type: 'line',
                data: [[1544770701,5], [1544770703,20], [1544770805,36]]
            },{
                name: 'series2',
                type: 'line',
                data: [[1544770702,5], [1544770704,20], [1544770806,36]]
            }]
        }

The stated problem is caused by these lines: lib/component/axisPointer/axisTrigger.js#198-203, I don't know the purpose of these codes, but when i comment out line 198~203, the resulted behavior is what i want.

If you guys think this is a wanted behavior, then i request an option to do this.

 // if (dist < minDist || diff >= 0 && minDiff < 0) {
      //   minDist = dist;
      //   minDiff = diff;
      //   snapToValue = seriesNestestValue;
      //   payloadBatch.length = 0;
      // }

Topics

[ ] Legend
[x] Tooltip
[ ] Event
[ ] Performance
[ ] SVG
[ ] Map
[ ] ECharts GL
[ ] Third-party libraries, e.g.: Vue.js, React

Anything Else We Need to Know

Environment

ECharts version；ECharts 版本: 4.2.0-rc.2 / 3.7.2 (it happens in both version, you can try in js fiddle)
[ ] It happens only on certain browsers or operating systems. 对于特定浏览器或操作系统才会出现的问题，请提供相应环境信息：{BROWSER_VERSION_OR_OS_INFORMATION_HERE}

Ovilia commented 5 years ago

Because the x value of the two series are not the same. The first one is 1544770701 and the second one is 1544770702. But I think this should be improved so that all series are shown in tooltip when trigger is set to be axis.

100pah commented 5 years ago

As @Ovilia mentioned, I think if you intent to display both series in a tooltip, the x value should be the same.

If we make all of the series displayed in tooltip mandatorily in this case, when a axisPointer is on a X value and some series do not have Y value corresponding to that x value, which data item should be selected to show on tooltip? I think it is not reasonable enough to choose a closest item to show on tooltip, because it may miss leading the readers.

buhichan commented 5 years ago

I don't see it's a misleading. The difference is only 1 second, it is ignorable. It's very common when you have multiple sourced time series data and their sampling rate are not synchronized. If I don't have the option to do this (show the closest point), I am forced to modify the x value so that they are at the same x, but that would be misleading the viewers.

IkerZamora commented 4 years ago

Any update on this?

Ovilia commented 4 years ago

I think it's reasonable to display the two series if x axis has snap setting to be true. Let's see what we can do after we fix #7651.

Wintermute79 commented 2 years ago

Maybe same as #15488 ?

apache / echarts