search

apache / eventmesh

EventMesh is a new generation serverless event middleware for building distributed event-driven applications.
https://eventmesh.apache.org/
Apache License 2.0
1.6k stars 636 forks source link

[Enhancement] Do some code optimization.[consumer.go] #3772

Open Alonexc opened 1 year ago

Alonexc commented 1 year ago

Search before asking

Enhancement Request

This issue is a subproject issue of eventmesh. the subproject address is:

https://github.com/apache/eventmesh-go

image image located at: eventmesh-go/plugin/connector/rocketmq/consumer.go line 105,140,173,186,219 analysis and expalanation: 186-221 lines are duplicate of plugin/connector/rocketmq/consumer.go:140-175 (dupl)

Describe the solution you'd like

Ranme _ image

Repeat code extraction as method. image image

Are you willing to submit PR?

github-actions[bot] commented 2 months ago

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.