apache / eventmesh

EventMesh is a new generation serverless event middleware for building distributed event-driven applications.
https://eventmesh.apache.org/
Apache License 2.0
1.59k stars 634 forks source link

Use YAML file to store configuration #481

Open ruanwenjun opened 3 years ago

ruanwenjun commented 3 years ago

Enhancement Request

Currently, there are a lot of configuration fields in EventMesh, and it will increase in the future, you can look up at eventmesh.properties. Such as:

eventMesh.server.idc=DEFAULT
eventMesh.server.env=PRD
eventMesh.server.cluster=COMMON
eventMesh.server.name=EVENTMESH-runtime
eventMesh.sysid=0000
eventMesh.server.http.port=10105
########################## eventMesh tcp configuration ############################
eventMesh.server.tcp.enabled=true
eventMesh.server.tcp.port=10000
eventMesh.server.tcp.readerIdleSeconds=120
eventMesh.server.tcp.writerIdleSeconds=120
eventMesh.server.tcp.allIdleSeconds=120
eventMesh.server.tcp.clientMaxNum=10000
# client isolation time if the message send failure
eventMesh.server.tcp.pushFailIsolateTimeInMills=30000

It is difficult to find out which is your want since most of them has the same prefix. It is better to store them at yaml file, the advantage is that you can merge the common prefixes like below:

eventMesh:
  server:
    idc: DEFAULT
    env: PRD
    cluster: COMMON
    name: EVENTMESH-runtime
    http:
      port: 10105
    tcp:
      enabled: true
      port: 10000
      readerIdleSeconds: 120
      writerIdleSeconds: 120
      allIdleSeconds: 120
      clientMaxNum: 10000
      pushFailIsolateTimeInMills: 30000 # client isolation time if the message send failure
  sysid: 0000
qqeasonchen commented 3 years ago

good suggestion

Jackzeng1224 commented 3 years ago

It can be revised and submitted to pr

github-actions[bot] commented 4 months ago

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.