[Feature] Support Opentelemetry

apache / eventmesh

EventMesh is a new generation serverless event middleware for building distributed event-driven applications.

https://eventmesh.apache.org/

Apache License 2.0

1.57k stars 621 forks source link

[Feature] Support Opentelemetry #4857

Open qqeasonchen opened 1 month ago

qqeasonchen commented 1 month ago

Search before asking

[X] I had searched in the issues and found no similar issues.

Feature Request

Integrate opentelemetry SDK for tracing collecting.

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[ ] I agree to follow this project's Code of Conduct *

okareyou commented 1 month ago

Are there any specific implementation requirements?

Pil0tXia commented 1 month ago

@okareyou Welcome. You may refer to https://eventmesh.apache.org/docs/design-document/observability/metrics-export/ chapter.

qqeasonchen commented 1 month ago

https://opentelemetry.io/docs/languages/java/ @okareyou

okareyou commented 1 month ago

I checked out the EventMesh code and it looks like it's using OpenTelemetry for both metrics and tracing. Does that mean it's already set up with the OpenTelemetry SDK? Could I be missing something? Any advice would be great.

https://opentelemetry.io/docs/languages/java/ @okareyou

@okareyou Welcome. You may refer to https://eventmesh.apache.org/docs/design-document/observability/metrics-export/ chapter.

Pil0tXia commented 1 month ago

@okareyou

I'm not familier with trace-plugin yet. opentelemetry-sdk has been introduced in trace-plugin api:

https://github.com/apache/eventmesh/blob/e349def6a4eba61b94a8e5b8aeb4ddf9745cfbe7/eventmesh-trace-plugin/eventmesh-trace-api/build.gradle#L23-L24

May be we need some enhancement for trace-plugin? @qqeasonchen

Pil0tXia commented 6 days ago

@okareyou You may want to look at the trace-plugin to see if it has implemented the tracing collecting feature, and if this feature supports OpenTelemetry.