search

apache / eventmesh

EventMesh is a new generation serverless event middleware for building distributed event-driven applications.
https://eventmesh.apache.org/
Apache License 2.0
1.6k stars 636 forks source link

[Enhancement] Adding Flow control RateLimiter support in Http Message Send Processor #523

Closed jinrongluo closed 2 years ago

jinrongluo commented 3 years ago

Enhancement Request

In Eventmesh runtime, there is flow control using RateLimiter in TCP MessageTransfer processor, and HTTP Batch Message send processor. However flow control is missing in Http MessageSend (Sync & Async) procrssors.

I have implemented RateLimiter for Http Message Send processors, and would like to contribute.

I will create a PR later.

Is your enhancement request related to a problem? Please describe

Adding RateLimiter to Http Message Send Processor.

Using property file to set the rate limit

Describe the solution you'd like

Implementation is similar to Ratelimiter for TCP and HTTP Batch Send

Describe alternatives you've considered

Additional context

qqeasonchen commented 3 years ago

good question, you can refer to tcp ratelimiter implementation.

jinrongluo commented 3 years ago

thanks @qqeasonchen I created PR - https://github.com/apache/incubator-eventmesh/pull/524

Please review. thanks.

jinrongluo commented 2 years ago

PR merged, close issue.