search

apache / flagon-useralejs

Apache Flagon UserALE is a comprehensive, thin-client behavioral logging tool
https://flagon.apache.org/
Apache License 2.0
26 stars 26 forks source link

Feat(now don't need to add so much info for adding a commit): #476

Closed Suvendu-UI closed 4 months ago

Suvendu-UI commented 4 months ago

implementted commitizen easy to commit

fixed #477 Screenshot 2024-07-07 214606 Screenshot 2024-07-07 214619 Screenshot 2024-07-07 214632

EandrewJones commented 4 months ago

Hi @Suvendu-UI, thanks for the PR and your interest in the project! We always welcome contributions.

I see this commit is for #447. We encourage discussion prior to opening PRs to help ensure alignment. Per the comments, we felt this issue needs more discussion before acting on a solution:

We do not necessarily want to manage version updates at the commit level. Is there a way to do this via commitizen or do we need an alternative?

I would love for you to work with us to find the right solution and help shepherd this PR through. I'll tag you in further discussion on the issue.

See here. I'm inclined to make this ticket just for commitizen.

Suvendu-UI commented 4 months ago

Hey, @EandrewJones , how are you, i was looking for easier ways to commit the changes without much hecticness involved , i was googling it and got a automated ai which commits instantly which is almost equiv. to commitizen.

Here is the link https://github.com/christian-gama/autocommit

EandrewJones commented 4 months ago

Hi Suvenda,

Flagon is very particular about its dependency footprint. We try to keep the tree as small as possible and only use well established tools. Committizen passes that bar, autocommit does not.

Moreover, we believe contributors should write their own commit messages. Commit messages should be concise, relevant, clear, and consistent in style. There's no need to try to add AI (extra complexity) for something as simple as commits.

Best

Evan Jones Website: www.ea-jones.com

On Mon, Jul 8, 2024 at 2:14 PM Suvendu-UI @.***> wrote:

Hey, @EandrewJones https://github.com/EandrewJones , how are you, i was looking for easier ways to commit the changes without much hecticness involved , i was googling it and got a automated ai which commits instantly which is almost equiv. to commitizen.

Here is the link https://github.com/christian-gama/autocommit

— Reply to this email directly, view it on GitHub https://github.com/apache/flagon-useralejs/pull/476#issuecomment-2214868434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2T6ANBDCRZXY2XXZYWRVTZLLJJNAVCNFSM6AAAAABKPPOZO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUHA3DQNBTGQ . You are receiving this because you were mentioned.Message ID: @.***>

Suvendu-UI commented 4 months ago

Hey @Jyyjy i think i have resolved the requested changes

EandrewJones commented 4 months ago

@Suvendu-UI There's a tiny conflict that needs to be resolved before we can merge this. You should be able to:

  1. rebase this branch on top of the latest changes from master
  2. select either package-lock.json file, i.e. git checkout --ours package-lock.json
  3. reinstall, build, and push

Pinging @Jyyjy for his final look over.

Suvendu-UI commented 4 months ago

done all the steps @EandrewJones and @Jyyjy

EandrewJones commented 4 months ago

@Suvendu-UI There's still a conflict on package-lock.json.

Are you sure you've pulled down the most up-to-date changes from the upstream repo, i.e. apache/flagon-useralejs as opposed to just your fork (Suvendu-UI/flagon-useralejsGSOC)?

I see you're working directly off master on your fork (not recommended, but okay for now). That changes the steps slightly.

To be more explicit:

  1. git checkout master
  2. git pull upstream master where upstream points to the apache repo
  3. git push origin master where origin points to your fork
  4. This will raise a conflict in your package-lock.json. You should be able to resolve it by simply deleting the file, then re-installing npm install.
  5. Commit your changes and push them to your fork.
Suvendu-UI commented 4 months ago

now all resolved i guess @EandrewJones

Suvendu-UI commented 4 months ago

i don't know why but i am unable to pass the npm ci error , i have tried all the possible method reinstalling the package-lock and package file fsversion , can you help me?

EandrewJones commented 4 months ago

i don't know why but i am unable to pass the npm ci error , i have tried all the possible method reinstalling the package-lock and package file fsversion , can you help me?

I just got a chance to look into this. I've never seen this issue before :exploding_head:

Let's try a few things:

  1. Can you share what node and npm versions you're using? Please ensure you're using a Node version >= 18.x.x. If you're not already using NVM, I recommend it (see here for more details).
  2. Check the suggested fixes here

You may need to delete the node_modules and package-lock.json, then using correct node version, try running npm i && npm ci.