search

apache / fluo-muchos

Apache Fluo Muchos
https://fluo.apache.org
Apache License 2.0
26 stars 37 forks source link

Add validation checks for Azure deployments #395

Closed karthick-rn closed 3 years ago

karthick-rn commented 3 years ago

This PR includes only additional checks for Azure deployments, does not change any functional behaviour and independent of the other 2 parts. Addresses part3 in #392

keith-turner commented 3 years ago

@karthick-rn I am attempting to review this, but do not know python well enough to give a good review quickly. I am still looking at it though.

karthick-rn commented 3 years ago

@arvindshmicrosoft ran into some issues with these changes, I'm currently looking into this and will update the PR.

karthick-rn commented 3 years ago

I'm revisiting some parts of the code in this PR. Will update the PR once the testing is complete.

karthick-rn commented 3 years ago

@arvindshmicrosoft Hi, Thanks for taking the time to review this PR and also for helping me out to refine this work further and cover few more checks. Based on our last discussion I have applied the changes in this 1c5c08f. I have tested these changes against the following scenarios successfully

I have also included a TODO in azure/test_config.py for future work on adding test cases.

ctubbsii commented 3 years ago

I have no more comments on this, and am approving. But please do follow through on @ctubbsii observations.

I don't have anything further. Feel free to merge if you're happy with the other reviewers

karthick-rn commented 3 years ago

Thanks for all your comments and time in reviewing this PR. I'll go ahead and merge it.