search

apache / fluo-muchos

Apache Fluo Muchos
https://fluo.apache.org
Apache License 2.0
26 stars 37 forks source link

Update accumulo-env.sh for external compactions #396

Closed keith-turner closed 3 years ago

arvindshmicrosoft commented 3 years ago

Low priority question - I noticed that the CI checks ran twice. I figured this is because Keith pushed his branch to this repo - which caused the push trigger for the CI to activate; in addition to that, the regular pr trigger activated as well. @keith-turner, I was curious if there was any reason why you pushed your branch to this remote directly?

keith-turner commented 3 years ago

I was curious if there was any reason why you pushed your branch to this remote directly?

@arvindshmicrosoft I used the Github UI to make the change and it does that. I wish it would create the branch in my fork, but it does not. I was in a bit of a hurry when I made the change, I don't use GH web ui often for changes because it create the branch. Thanks for deleting the branch @ctubbsii, I should have done that when I merged.

ctubbsii commented 3 years ago

I used the Github UI to make the change and it does that.

Yeah, I've been annoyed by that too. If you don't have write access, and try to edit a file using GitHub's built-in text editor, it creates a branch in your fork. If you do have write access, it doesn't ask, but just creates the branch in the upstream repo. Very annoying. It should at least prompt which fork you want to create the branch in.

Thanks for deleting the branch

No problem :smiley_cat: