Closed arvindshmicrosoft closed 2 years ago
Given the valid observations / concerns raised by @ctubbsii I am abandoning the PR. As he pointed out, the code bloat and possible reduced functionality do not justify proceeding.
Given the valid observations / concerns raised by @ctubbsii I am abandoning the PR. As he pointed out, the code bloat and possible reduced functionality do not justify proceeding.
Sorry. I didn't mean to be a "party pooper". I thought maybe I was missing something. No harm done by the attempt to streamline, though!
Remove special case handling for SNAPSHOT tarballs - we now compute checksums for all relevant tarballs found in conf/upload. Those checksums are available to the Ansible download tasks, thereby further validating uploaded files.
Compute the expected local tarball name based on software versions specified in muchos.props. Then, if a matching local tarball is found, copy the tarball to the Ansible host ("proxy"). Locally found tarballs which do not match the configured version, are skipped (previously, all .tar.gz files from conf/upload would be blindly copied to proxy, regardless of whether they are actually needed).
Add simple tests to validate expected local tarball name for Accumulo and Zookeeper (the latter is especially important as it exercises the recursive expansion of Jinja2 templated variables in the Ansible host variables).