search

apache / fluo-muchos

Apache Fluo Muchos
https://fluo.apache.org
Apache License 2.0
26 stars 37 forks source link

Improve support for Fedora AMIs #429

Closed ctubbsii closed 2 years ago

ctubbsii commented 2 years ago

Based on the recent mailing list discussion, I decided to test Muchos with Fedora. It mostly works, but needs some changes. This PR also proposes changing the default AMI for EC2 to a recent Fedora 35 AMI, but that is not critical, and can be reverted before this PR is merged.

arvindshmicrosoft commented 2 years ago

@ctubbsii - how would you like to proceed with this? The only question in my mind is whether (or not) to change the default AMI for EC2. On the Azure side, there are some challenges with broad availability of Fedora / Alma / CentOS Stream images so we will likely retain the older CentOS 7.9 default for Azure for a bit longer. As mentioned above, the changes in this PR do not have any side-effects on CentOS 7.9, so it LGTM.

@keith-turner - would appreciate your input.

ctubbsii commented 2 years ago

@ctubbsii - how would you like to proceed with this? The only question in my mind is whether (or not) to change the default AMI for EC2.

My intent was to support Fedora more easily, and to show how similar Fedora and other distros in the same "distro-family" are to the EL7 distros that already work out of the box that we've been using. I was pleasantly surprised to find that EL8 distros were already supported by conditional logic in our ansible playbooks, and aside from the need to use epel-release yum repo for that, EL8 distros seems identical to Fedora, which means Fedora hasn't diverged too much from when EL8 was forked from it.

At a minimum, I'd like to merge the conditional logic that I added in the ansible/ directory to better support Fedora. I'd also like to merge the test changes so we're not so tightly coupled to current example config values, but don't lose any test coverage.

I was hoping to defer to the community consensus on whether to change the example config. If the other changes are acceptable, but we want to move that out into a separate PR for further consideration, I can do that. I'll await community consensus on that. I'd be just as happy using an Alma, Rocky, or CentOS 8 Stream AMI by default.

(Note: I also changed the default filesystem format from ext3 to ext4 in this PR, but that was just because I don't see a reason to use the older generation of ext when the newer one is supported. It's not a Fedora-specific change. I didn't test it with CentOS 7, though I'm pretty sure CentOS 7 supports ext4 just fine.)