search

apache / fury

A blazingly fast multi-language serialization framework powered by JIT and zero-copy.
https://fury.apache.org/
Apache License 2.0
3.05k stars 236 forks source link

[CODE HEADERS] Can we remove the author tags from the Fury code covered by the code grant? #1281

Closed pjfanning closed 9 months ago

pjfanning commented 9 months ago

It appears to be unusual to have author tags in ASF code bases. There are exceptions for code that is borrowed from 3rd party sources - if it was not explicitly granted to the ASF.

chaokunyang commented 9 months ago

Hi PJ, do you mean the java doc author tag like:

/**
 * Thread safe serializer interface. {@link Fury} is not thread-safe, the implementation of this
 * interface will be thread-safe. And support switch classloader dynamically.
 *
 * @author chaokunyang
 */
chaokunyang commented 9 months ago

We have such tags before joining ASF. If it's not recommanded, I can create a PR to remove it all

pjfanning commented 9 months ago

Yes - it is the @author tags that I am referring to.

The ASF likes the idea of collective code owenership. The git history and git blame give a good idea of authorship anyway.

chaokunyang commented 9 months ago

Will be removed in #1282

pjfanning commented 9 months ago

https://whimsy.apache.org/board/minutes/Confirming_that_the_current_stance_on__author_tags_as.html

It is a recommendation (strong one) that the tags are removed but the PPMC could decide to allow them, if people are very attached to them.

chaokunyang commented 9 months ago

I think tags can be removed. Currently only java code contains @author.