search

apache / fury

A blazingly fast multi-language serialization framework powered by JIT and zero-copy.
https://fury.apache.org/
Apache License 2.0
2.96k stars 218 forks source link

Consider to rewrite shell scripts in Python #1299

Open PragmaTwice opened 8 months ago

PragmaTwice commented 8 months ago

TBH these CI scripts are hard to maintain (especially considering the difference between bash and zsh, and the difficulty to execute them on windows), we need a more structure language like python to make them readable and maintanable.

https://github.com/apache/incubator-fury/tree/main/ci

LiangliangSui commented 8 months ago

I totally agree with this, it can mask the differences in script syntax (e.g. windows script syntax is very unfriendly), and it is easier to write and code readable.

chaokunyang commented 8 months ago

Sounds good to me, but rewriting those scripts into python is not an easy work, and most scripts are used by CI only. I suggest we start from rewriting the scripts used by contributors everyday.

chaokunyang commented 8 months ago

This remind me of PyTorch. When you filing an issue, you can execute a python script from PyTorch, which can collect system information as much as it can, and print it. Then you can paste such information into the issue for trouble shooting

LiangliangSui commented 8 months ago

So can we start by rewriting the C++ CI Build script in Windows? such as run_ci.py

chaokunyang commented 8 months ago

Yep, we can start from rewriting the C++ CI Build script in Windows