Open orenccl opened 2 weeks ago
Hi @unknowntpo,
I've resolved the conflicts based on your recently merged PR #56.
Would you please review this? If possible, I would appreciate if you could also test it in your environment.
Thanks!
@orenccl Okay, I'll take a look :)
hi @orenccl Thank you for your improve playground
I think we didn't neet specify docker|k8s
param, we can check use environment,
if user only have docker, then launch playground on Docker
if use only have k8s, then launch playground on Docker
if use both have docker and k8s, then output a menu, let use select one to launch.
@xunliu I think letting user to run both k8s and docker is more handy.
Update this PR:
Please let me know if there are any problems.
Hi @orenccl would you please rebase this PR to fix the conflicts?
Update this PR:
Please let me know if there are any problems.
@orenccl Can you help check this issue when I ran the fileset example in jupyter? By the way ,we have 4 examples in jupyter, can you help verify them by access http://localhost:18888 ,especially k8s runtime.
Hi @danhuawang,
Sorry about this. I found that the commit Unified port number for Docker and Kubernetes actually caused some issues with internal communication within the Kubernetes cluster.
This should be addressed in a separate issue, so I have reverted it and focused on the original problem. I've also updated the README to clarify the container and host port mapping, so users won't be confused about which port to forward.
Could you review this when you have free time?
@orenccl conflicts need to be resolved.
@qqqttt123 Any comments?
What changes were proposed in this pull request?
set -x
.cd "${playground_dir}" >/dev/null
tocd "${playground_dir}" >/dev/null || exit 1
to prevent failures whencd
fails.docker run --pull always hello-world >/dev/null 2>&1
todocker run --rm --pull always hello-world:latest >/dev/null 2>&1
to avoid pulling multiple images and ensure the container is removed after it finishes.--skip-checks
option for a quicker startup.%Y%m%d%H%m%s
to%Y%m%d%H%M%s
.Confirm the requirement is available in your OS [Y/n]:
.Why are the changes needed?
To improve the user experience. close #102
Does this PR introduce any user-facing change?
Added a new option
--skip-checks|-s
for a quicker startup.How was this patch tested?
Tested with the following commands:
./playground start
./playground status
./playground stop
./playground start --skip-checks
./playground start -s
These tests were run to ensure the script works as intended.