apache / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://gravitino.apache.org
Apache License 2.0
1.09k stars 343 forks source link

[Bug report] alter mysql table set property using http request did not worked #2924

Open zhoukangcn opened 7 months ago

zhoukangcn commented 7 months ago

Version

main branch

Describe what's wrong

curl -X PUT -H "Accept: application/vnd.gravitino.v1+json" \
-H "Content-Type: application/json" -d '{
  "updates": [
    {
      "@type": "removeProperty",
      "property": "key2"
    }, {
      "@type": "setProperty",
      "property": "key3",
      "value": "value3"
    }
  ]
}' http://localhost:8090/api/metalakes/metalake/catalogs/mysql_test1/schemas/test/tables/test_table1

return 200, but something was wrong:

Error message and/or stacktrace

N/A

How to reproduce

add a MySQL catalog, database, table use bash beblow

Additional context

No response

yuqi1129 commented 7 months ago

@zhoukangcn I remember MySQL catalog only supports setting properties with names that are recognized by MySQL engine like engine,charset, and so on, maybe I have mistaken it.

zhoukangcn commented 7 months ago

I think Gravitino server return 200, which means request success.

Yes MySQL only support properties like engine charset, so I think Gravitino server should return 4xx for request invalid.

yuqi1129 commented 3 weeks ago

This issue needs to be discussed and then we can reach an agreement about what to do next, so I postponed it to the next version.