search

apache / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://gravitino.apache.org
Apache License 2.0
883 stars 288 forks source link

[Improvement] Configs.java interface has no interface definitions just constants #3029

Closed justinmclean closed 1 week ago

justinmclean commented 4 months ago

What would you like to be improved?

Configs.java interface has no interface definitions just constants.

How should we improve?

Use a final class with a private constructor instead.

lw-yang commented 4 months ago

I'll be adding some new configurations recently, I would like to refactor it together

shaofengshi commented 4 months ago

Assign to lw-yang so that won't be conflict with other guys.

justinmclean commented 1 month ago

@lw-yang do you still want to work on this?

lw-yang commented 1 month ago

Yes, i will complete it this week.

lw-yang commented 3 weeks ago

It has been resolved by https://github.com/apache/gravitino/pull/3404

justinmclean commented 1 week ago

Closing as it has been done