apache / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://gravitino.apache.org
Apache License 2.0
1.09k stars 343 forks source link

[Bug report] Can rename metalake when in simple name mode (which is default for playground) #3245

Closed justinmclean closed 3 months ago

justinmclean commented 6 months ago

Version

main branch

Describe what's wrong

You can rename the metalake and no error is given, even though the metalake name is specified in the configuration.

Error message and/or stacktrace

Once renamed you get endless errors: playground-trino | 2024-05-02T06:26:33.045Z INFO gravitino-connector-schedule-0 stdout 2024-05-02 06:26:33 WARN CatalogConnectorManager:116 - Metalake metalake_demo does not exist.

How to reproduce

Start the playground and rename the mekalake.

Additional context

No response

shaofengshi commented 6 months ago

If change metalake name in the Gravitino server side, the trino side doesn't get that, it still uses the original name to connect with Gravitino, then the "Metalake does not exit" error be reported. I think this is expected.

To make it work, user need to update the metalake name in trino side, which is "/etc/trino/catalog/gravitino.properties" in the trino container, and then restart Trino to make it effective.

justinmclean commented 6 months ago

The UI makes it easy to change the name, editing should be disabled if using simple names. The playground doesn't include the Trino admin tools needed to restart Trino.

jerqi commented 3 months ago

You need to restart the Trino if you rename the metalake and modify the configuration, so this isn't an issue. We should close it.