[#4018] feat(core): Add tag management logic for Tag System (Part 1)

apache / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.

https://gravitino.apache.org

Apache License 2.0

959 stars 302 forks source link

[#4018] feat(core): Add tag management logic for Tag System (Part 1) #4019

Closed jerryshao closed 2 months ago

jerryshao commented 3 months ago

What changes were proposed in this pull request?

This PR tracks the work of adding the core logics for tag management.

Why are the changes needed?

This is a part of work for adding tag support in Gravitino.

Fix: #4018

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UTs added.

jerryshao commented 3 months ago

@xloya @yuqi1129 @lw-yang can you please help me to review this? I use the transactions here for multiple step queries, I'm not so sure if it is correct or not, also I'm very sure we can really keep the consistency, or we have to introduce the lock here.

jerryshao commented 3 months ago

@yuqi1129 @xloya @lw-yang please help to review again.

yuqi1129 commented 2 months ago

Overall, LGTM is good except for a minor issue. Please let me know if it has been resolved or if there is any doubt.

yuqi1129 commented 2 months ago

@qqqttt123 @lw-yang Do you have any additional comments on the matter?

lw-yang commented 2 months ago

LGTM

xloya commented 2 months ago

LGTM