search

apache / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://gravitino.apache.org
Apache License 2.0
959 stars 302 forks source link

[#4065] improvement(test): Fix the path of integration log is wrong. #4029

Closed yuqi1129 closed 2 months ago

yuqi1129 commented 3 months ago

What changes were proposed in this pull request?

Why are the changes needed?

The path is not right.

Fixed: #4065

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Test locally.

Before

image

After

image

zhoukangcn commented 3 months ago

@yuqi1129 still have this problem with command ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false -x :clients:client-python:build which is used in build.yml

image
yuqi1129 commented 3 months ago

@yuqi1129 still have this problem with command ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false -x :clients:client-python:build which is used in build.yml

image

Do you reproduce it in this branch (yuqi1129:minor) or the main branch?

zhoukangcn commented 3 months ago

@yuqi1129 still have this problem with command ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false -x :clients:client-python:build which is used in build.yml

image

Do you reproduce it in this branch (yuqi1129:minor) or the main branch?

on branch yuqi1129:minor

yuqi1129 commented 3 months ago

@yuqi1129 still have this problem with command ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false -x :clients:client-python:build which is used in build.yml

image

Do you reproduce it in this branch (yuqi1129:minor) or the main branch?

on branch yuqi1129:minor

Let me check it.

yuqi1129 commented 3 months ago

@yuqi1129 still have this problem with command ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false -x :clients:client-python:build which is used in build.yml

image

Do you reproduce it in this branch (yuqi1129:minor) or the main branch?

on branch yuqi1129:minor

Let me check it.

It seems that the system property in the log configuration file does not work

image
yuqi1129 commented 2 months ago

@zhoukangcn Could you help to review it again?

zhoukangcn commented 2 months ago

@zhoukangcn Could you help to review it again?

OK，I will check it later

zhoukangcn commented 2 months ago
image

@yuqi1129 Does this meet the expectations?

yuqi1129 commented 2 months ago

image @yuqi1129 Does this meet the expectations?

@zhoukangcn I think so, @diqiu50 . Can you help to confirm it?

zhoukangcn commented 2 months ago

Others LGTM

diqiu50 commented 2 months ago

image @yuqi1129 Does this meet the expectations?

@zhoukangcn I think so, @diqiu50 . Can you help to confirm it?

That's fine. It's the Trino container logs

yuqi1129 commented 2 months ago

It's the Trino container logs

OK