search

apache / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://gravitino.apache.org
Apache License 2.0
1.1k stars 345 forks source link

[Improvement] Support clear up entry comment #4112

Closed bknbkn closed 4 months ago

bknbkn commented 4 months ago

What would you like to be improved?

While using fileset, users sometimes want to clear the existing comments, but now they cannot pass the validation because newComment cannot be empty. Is it possible to delete the validation?

How should we improve?

Delete the validation of newComment in fileset, maybe it can also be applied to metalake or table

bknbkn commented 4 months ago

@jerryshao what do you think about it

jerryshao commented 4 months ago

I think it is not proper to use newComment to achieve this, maybe we can have a new Change to support this?

bknbkn commented 4 months ago

Ok, maybe we can add new change removeComment

coolderli commented 4 months ago

Ok, maybe we can add new change removeComment

@bknbkn It's a little strange. Why did the user remove the comment? Do we need to restrict the frontend to not allow comments to be empty？

bknbkn commented 4 months ago

@coolderli Because user can create a fileset without comment now, when they added a comment to fileset, It should be allowed to retract the comment and return to original created status