search

apache / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://gravitino.apache.org
Apache License 2.0
1.1k stars 350 forks source link

#5440 fix(web): include missing JDBC properties in catalog creation payload for Apache Iceberg #5441

Closed niyushabaghayi closed 4 weeks ago

niyushabaghayi commented 4 weeks ago

Why are the changes needed? These changes are needed to address a bug in the Gravitino UI that prevents users from successfully creating a catalog with type: relational and provider: Apache Iceberg. The missing properties cause a 400 error on the backend, blocking catalog creation.

Fix: #5440

Does this PR introduce any user-facing change? Yes, this PR allows users to create catalogs with type: relational and provider: Apache Iceberg without encountering a 400 error due to missing JDBC properties. It resolves the issue of incomplete payloads and improves catalog creation reliability.

How was this patch tested?

  1. Manual Testing:

    • Opened the "Create Catalog" dialog in the Gravitino UI.
    • Set type to relational, provider to Apache Iceberg, and configured catalog-backend as jdbc with appropriate jdbc-driver, jdbc-user, and jdbc-password values.
    • Clicked "Create" and verified successful catalog creation without errors.

  2. Steps to Test: Follow the reproduction steps outlined in the issue report to confirm that the changes address the problem.

  3. Edge Cases: Tested with catalog-backend set to jdbc and verified correct behavior.

jerryshao commented 4 weeks ago

@LauraXia123 would you please help to review this PR?

LauraXia123 commented 4 weeks ago

@niyushabaghayi hi, the latest commit have no issue about #5440 , let me know if you have any problems after retesting!

niyushabaghayi commented 3 weeks ago

Thanks, @LauraXia123! Could you please point me to the specific issue and related PR that resolved this problem? I tried searching but couldn't find it, and I'm still experiencing the issue on the latest version (Gravitino 0.6.1-incubating). Any guidance would be greatly appreciated!

LauraXia123 commented 3 weeks ago

Fixed on (Gravitino 0.7.0-incubating), you can retry it on main branch or tag (v0.7.0-incubating-rc2). You can find the dup issue: https://github.com/apache/gravitino/issues/5328