search

apache / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://gravitino.apache.org
Apache License 2.0
1.1k stars 348 forks source link

[#5518] feat(iceberg): add http header and remote addr information to Iceberg Event #5495

Closed FANNG1 closed 2 weeks ago

FANNG1 commented 3 weeks ago

What changes were proposed in this pull request?

  1. add HTTP header to event listener context
  2. add remote IP addr to event listener context

Why are the changes needed?

Fix: #5518

Does this PR introduce any user-facing change?

no

How was this patch tested?

setup a local app and check IP addr and HTTP header was added to context

FANNG1 commented 2 weeks ago

@jerryshao @puchengy it's ready to review now, please help to review again.

FANNG1 commented 2 weeks ago

After this PR is merged, you could add Http header information to Gravitino server event too, and then make audit frame work to generate audit log for both Gravitino server and Gravitino IcebergREST server.

puchengy commented 2 weeks ago

nit, the title of the PR should be expanded to include ip address (and possibly remote hostname if my suggestion is implemented).

puchengy commented 2 weeks ago

@FANNG1 Thank you, LGTM, left some nits.