search

apache / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://gravitino.apache.org
Apache License 2.0
1.09k stars 343 forks source link

[#5593] improvement(iceberg): Add final to Iceberg table event members, fix return codes for rename and exists operations #5594

Closed orenccl closed 4 days ago

orenccl commented 5 days ago

What changes were proposed in this pull request?

  1. Add final to Iceberg table-related events and their members.

  2. Modify the return codes in IcebergTableOperations and IcebergTableRenameOperations to align with the specification, and update the relevant unit tests.

Why are the changes needed?

Close: #5593

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit test

FANNG1 commented 5 days ago

@orenccl thanks for your PR, could you fix exists return code in name space operation too?

orenccl commented 5 days ago

Hi @FANNG1,

I checked IcebergNamespaceOperations and Iceberg's catalogHandlers, but didn't find anything like namespaceExists. It seems there isn't an existing function for that.

So, no modifications are needed here?

FANNG1 commented 5 days ago

Hi @FANNG1,

I checked IcebergNamespaceOperations and Iceberg's catalogHandlers, but didn't find anything like namespaceExists. It seems there isn't an existing function for that.

So, no modifications are needed here?

OOH, seems we forget to implement this interface, this is another issue.

FANNG1 commented 4 days ago

@orenccl , merged to main, thanks for your work and insight.