apache / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://gravitino.apache.org
Apache License 2.0
1.1k stars 344 forks source link

[Improvement] support schema exists interface for Iceberg REST server #5611

Closed FANNG1 closed 4 days ago

FANNG1 commented 5 days ago

What would you like to be improved?

I checked IcebergNamespaceOperations and Iceberg's catalogHandlers, but didn't find anything like namespaceExists. It seems there isn't an existing function for that. https://github.com/apache/gravitino/pull/5594#issuecomment-2480547001

As mentioned by @orenccl , we doesn't implement namespace exists interface in Iceberg REST server. We could add the interface like table exists in https://github.com/apache/gravitino/blob/main/iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java#L237-L256, leveraging loadNamepace in CatalogHandlers to check whether namespace exists or not.

How should we improve?

No response

orenccl commented 5 days ago

Please assgn this to me.

FANNG1 commented 5 days ago

Thanks @orenccl for taking it.

orenccl commented 4 days ago

I was exploring and discovered that the SupportsNamespaces interface has an namespaceExists function.
You can find it here: SupportsNamespaces Javadoc.

FANNG1 commented 4 days ago

I was exploring and discovered that the SupportsNamespaces interface has an namespaceExists function. You can find it here: SupportsNamespaces Javadoc.

yes, this is a better way!