Open diqiu50 opened 4 days ago
suggest to do some auto check like cargo-machete
cargo-sort
cargo clippy
cargo fmt
, you could refer https://github.com/apache/iceberg-rust/blob/main/.github/workflows/ci.yml#L55-L68
@FANNG1 can you please help to review?
suggest adding basic check for code style and common errors in ci
cargo fmt --all -- --check
cargo clippy --all-targets --all-features --workspace -- -D warnings
@FANNG1 can you please help to review again? If there's no blocking issue, I think we can improve the building command in the following PRs, what do you think?
@FANNG1 can you please help to review again? If there's no blocking issue, I think we can improve the building command in the following PRs, what do you think?
Seems there're some basic issues to be addressed,
What changes were proposed in this pull request?
Set up a submodule project for the Gvfs-fuse, layout the rust module environment for gvfs-fuse
Why are the changes needed?
Fix: #5626
Does this PR introduce any user-facing change?
No
How was this patch tested?
No