apache / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://gravitino.apache.org
Apache License 2.0
1.1k stars 344 forks source link

[#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse #5627

Open diqiu50 opened 4 days ago

diqiu50 commented 4 days ago

What changes were proposed in this pull request?

Set up a submodule project for the Gvfs-fuse, layout the rust module environment for gvfs-fuse

Why are the changes needed?

Fix: #5626

Does this PR introduce any user-facing change?

No

How was this patch tested?

No

FANNG1 commented 4 days ago

suggest to do some auto check like cargo-machete cargo-sort cargo clippy cargo fmt, you could refer https://github.com/apache/iceberg-rust/blob/main/.github/workflows/ci.yml#L55-L68

jerryshao commented 3 days ago

@FANNG1 can you please help to review?

FANNG1 commented 3 days ago

suggest adding basic check for code style and common errors in ci

        cargo  fmt --all -- --check
        cargo  clippy --all-targets --all-features --workspace -- -D warnings
jerryshao commented 2 days ago

@FANNG1 can you please help to review again? If there's no blocking issue, I think we can improve the building command in the following PRs, what do you think?

FANNG1 commented 1 day ago

@FANNG1 can you please help to review again? If there's no blocking issue, I think we can improve the building command in the following PRs, what do you think?

Seems there're some basic issues to be addressed,

  1. Whether to build fuse-rust by default, I prefer not, because it's difficult for most persons.
  2. To enable code style and clippy check, I'm ok to add the check in this or next PR.
  3. Which rust fuse lib should we choose, if we doesn't have an answer for now, I prefer to remove the current fuse depedences.