apache / helix

Mirror of Apache Helix
Apache License 2.0
461 stars 224 forks source link

Mark HelixCustomeCodeRunner Deprecated #2774

Closed desaikomal closed 6 months ago

desaikomal commented 6 months ago

Issues

Description

Tests

(List the names of added unit/integration tests)

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Start zookeeper at localhost:2183 in thread main
START TestDisableCustomCodeRunner_test at Tue Mar 05 17:05:05 PST 2024
END TestDisableCustomCodeRunner_test at Tue Mar 05 17:05:18 PST 2024
AfterClass: TestDisableCustomCodeRunner called.
Shut down zookeeper at port 2183 in thread main

===============================================
Default Suite
Total tests run: 1, Failures: 0, Skips: 0
===============================================

and

Start zookeeper at localhost:2183 in thread main
START CLUSTER_TestHelixCustomCodeRunner at Tue Mar 05 17:06:43 PST 2024
true: ClusterStateVerifier$BestPossAndExtViewZkVerifier(CLUSTER_TestHelixCustomCodeRunner@localhost:2183): wait 1016ms to verify
END CLUSTER_TestHelixCustomCodeRunner at Tue Mar 05 17:07:01 PST 2024
AfterClass: TestHelixCustomCodeRunner called.
Shut down zookeeper at port 2183 in thread main

===============================================
Default Suite
Total tests run: 1, Failures: 0, Skips: 0
===============================================

Process finished with exit code 0

Changes that Break Backward Compatibility (Optional)

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

(Link the GitHub wiki you added)

Commits

Code Quality

himanshukandwal commented 6 months ago

LGTM, thanks @desaikomal

desaikomal commented 6 months ago

This change has been reviewed and approve by @junkaixue and @himanshukandwal. Final commit message: Deprecate HelixCustomCodeRunner as it is using deprecated GenericLeaderStandby.