[ ] My PR addresses the following Helix issues and references them in the PR description:
Description
[ ] Here are some details about my PR, including screenshots of any UI changes:
We have 'GenericLeaderStandbyModel' which has some ST processing not implemented and so if a participant node uses 'CustomRunner' they may see some error related to ST processing.
We are deprecating the GenericLeaderStandbyModel as well.
Tests
[ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Start zookeeper at localhost:2183 in thread main
START TestDisableCustomCodeRunner_test at Tue Mar 05 17:05:05 PST 2024
END TestDisableCustomCodeRunner_test at Tue Mar 05 17:05:18 PST 2024
AfterClass: TestDisableCustomCodeRunner called.
Shut down zookeeper at port 2183 in thread main
===============================================
Default Suite
Total tests run: 1, Failures: 0, Skips: 0
===============================================
and
Start zookeeper at localhost:2183 in thread main
START CLUSTER_TestHelixCustomCodeRunner at Tue Mar 05 17:06:43 PST 2024
true: ClusterStateVerifier$BestPossAndExtViewZkVerifier(CLUSTER_TestHelixCustomCodeRunner@localhost:2183): wait 1016ms to verify
END CLUSTER_TestHelixCustomCodeRunner at Tue Mar 05 17:07:01 PST 2024
AfterClass: TestHelixCustomCodeRunner called.
Shut down zookeeper at port 2183 in thread main
===============================================
Default Suite
Total tests run: 1, Failures: 0, Skips: 0
===============================================
Process finished with exit code 0
Changes that Break Backward Compatibility (Optional)
My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
Commits
My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"
Code Quality
My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
This change has been reviewed and approve by @junkaixue and @himanshukandwal.
Final commit message: Deprecate HelixCustomCodeRunner as it is using deprecated GenericLeaderStandby.
Issues
Description
Tests
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
and
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality