search

apache / hertzbeat

Apache HertzBeat(incubating) is a real-time monitoring system with agentless, performance cluster, prometheus-compatible, custom monitoring and status page building capabilities.
https://hertzbeat.apache.org/
Apache License 2.0
5.63k stars 976 forks source link

[Question] Support querying via prometheus for rocketMQ #1810

Open Alanxtl opened 6 months ago

Alanxtl commented 6 months ago

Question

According to the doc, rocketMQ is supported for querying metrics using the Prometheus protocol. Currently the code seems to use the method of creating an instance to query information (https://github.com/apache/hertzbeat/pull/1046), so the metrics that could be queried seems limited and its a waste of connection resource. I think it is necessary to support querying via prometheus for rocketMQ.

btw, I'm not sure if I should create a [Task], so I just create a [Question].

tomsun28 commented 6 months ago

@Ceilzcx how about this, suggest use Prometheus protocol to query the rocketMQ metrics too.

Ceilzcx commented 6 months ago

Can you briefly describe the advantages of changing to this？ Because now too few metrics to monitor rocketmq，and sdk is not support or other reason？

Alanxtl commented 6 months ago

@Ceilzcx, according to https://github.com/apache/rocketmq/issues/5615#issuecomment-1331634113 and RIP-46, they have introduced new metrics in Prometheus way. See doc for detailed metrics.

Besides, RIP-46, also mentioned that

using mqadmin tools, which puts additional pressure on broker and client.

Ceilzcx commented 6 months ago

@Ceilzcx, according to apache/rocketmq#5615 (comment) and RIP-46, they have introduced new metrics in Prometheus way. See doc for detailed metrics.

Besides, RIP-46, also mentioned that

using mqadmin tools, which puts additional pressure on broker and client.

good idea. Need to be compatible with old logic？

Alanxtl commented 6 months ago

@Ceilzcx, according to apache/rocketmq#5615 (comment) and RIP-46, they have introduced new metrics in Prometheus way. See doc for detailed metrics. Besides, RIP-46, also mentioned that

using mqadmin tools, which puts additional pressure on broker and client.

good idea. Need to be compatible with old logic？

I do not think it is necessary, the new method covers the metrics of the old one can query after all.