feature: add column Version and Public Ip on Collector page

apache / hertzbeat

Apache HertzBeat(incubating) is a real-time monitoring system with agentless, performance cluster, prometheus-compatible, custom monitoring and status page building capabilities.

https://hertzbeat.apache.org/

Apache License 2.0

5.17k stars 903 forks source link

feature: add column Version and Public Ip on Collector page #2072

Closed Calvin979 closed 3 weeks ago

Calvin979 commented 1 month ago

What's changed?

Relate issue: #1549

Seems it is difficult to get public ip in Java directly, therefore I add a configuration public-ip-env for getting public ip from environment.

Checklist

[x] I have read the Contributing Guide
[ ] I have written the necessary doc or comment.
[ ] I have added the necessary unit tests and all cases have passed.

Add or update API

[ ] I have added the necessary e2e tests and all cases have passed.

tomsun28 commented 1 month ago

hi thanks lgtm !👍👍 Suggest we can combine the ip and public ip into one ip.
When user custom config the collector ip like below, we use the custom ip, else we use the ip we detect by program like before.

collector:
  info: 
     version: 1.5.0
     ip: 38.44.3.5

Calvin979 commented 1 month ago

hi thanks lgtm !👍👍 Suggest we can combine the ip and public ip into one ip. When user custom config the collector ip like below, we use the custom ip, else we use the ip we detect by program like before.
collector:
  info: 
     version: 1.5.0
     ip: 38.44.3.5

Code has been updated by your suggestion.