[bugfix] fix deleting component error

apache / hertzbeat

Apache HertzBeat(incubating) is a real-time monitoring system with agentless, performance cluster, prometheus-compatible, custom monitoring and status page building capabilities.

https://hertzbeat.apache.org/

Apache License 2.0

5.12k stars 897 forks source link

[bugfix] fix deleting component error #2152

Closed LiuTianyou closed 5 days ago

LiuTianyou commented 5 days ago

What's changed?

fix deleting component error about (#2147)
add i18n support to backend services

Checklist

[ ] I have read the Contributing Guide
[ ] I have written the necessary doc or comment.
[ ] I have added the necessary unit tests and all cases have passed.

Add or update API

[ ] I have added the necessary e2e tests and all cases have passed.

tomsun28 commented 5 days ago

Hi, there's onething we need to discuss. Whether we need to use i18n errors and data in the restful api response, before only in the user-facing level in the webapp to show i18n message, for the developer-facing api layer directly use the English message due we think english notice message for developers is enough.

LiuTianyou commented 5 days ago

Hi, there's onething we need to discuss. Whether we need to use i18n errors and data in the restful api response, before only in the user-facing level in the webapp to show i18n message, for the developer-facing api layer directly use the English message due we think english notice message for developers is enough.

Got it, I will remove the i18n information returned by the API and use English error messages to keep it consistent with the current design.