[refactor] move code from AccountController to AccountService

apache / hertzbeat

Apache HertzBeat(incubating) is a real-time monitoring system with agentless, performance cluster, prometheus-compatible, custom monitoring and status page building capabilities.

https://hertzbeat.apache.org/

Apache License 2.0

5.47k stars 950 forks source link

[refactor] move code from AccountController to AccountService #2373

Closed Calvin979 closed 1 month ago

Calvin979 commented 1 month ago

What's changed?

As a layer of interaction with front-end, controller should not contain any code logic.

Checklist

[x] I have read the Contributing Guide
[ ] I have written the necessary doc or comment.
[x] I have added the necessary unit tests and all cases have passed.

Add or update API

[ ] I have added the necessary e2e tests and all cases have passed.

Calvin979 commented 1 month ago

@tomsun28 There are some controllers have the same problem like this pr. Shall we create an issue for newcomers?

tomsun28 commented 1 month ago

@tomsun28 There are some controllers have the same problem like this pr. Shall we create an issue for newcomers?

hi, ok. 👍