search

apache / hertzbeat

Apache HertzBeat(incubating) is a real-time monitoring system with agentless, performance cluster, prometheus-compatible, custom monitoring and status page building capabilities.
https://hertzbeat.apache.org/
Apache License 2.0
5.46k stars 947 forks source link

[Task] <Move code from controller to service in module hertzbeat-manager> #2407

Closed Calvin979 closed 1 month ago

Calvin979 commented 1 month ago

Description

Move code from controller to service in module hertzbeat-manager. See also: #2373 As a layer of interaction with front-end, controller should not contain any code logic except param validation.

Comment down below if you want to claim task. eg: I claim xxxController

Task List

ceekay47 commented 1 month ago

Hi @Calvin979, I would like to contribute. I can look into refactoring CollectorController to get started. Can you please provide some context?

pwallk commented 1 month ago

I can finish the rest of the controller

Calvin979 commented 1 month ago

Hi @Calvin979, I would like to contribute. I can look into refactoring CollectorController to get started. Can you please provide some context?

Welcome! Maybe you can refer this pr: #2373 The key is that the responsibility of Controller is to validate param only. There are some controllers contain a lot of codes out of its responsiblity and that's why we wanna refactor them.

Calvin979 commented 1 month ago

I can finish the rest of the controller

Welcome! Suggest one pr for one controller only.

MRgenial commented 1 month ago

I claim collectorController

Calvin979 commented 1 month ago

I claim collectorController

Thanks for your enthusiasm. CollectorController has been assigned to @ceekay47. You can try to find another issue