apache / hop

Hop Orchestration Platform
https://hop.apache.org/
Apache License 2.0
981 stars 351 forks source link

[Bug]: Filter rows for mumeric values #2573

Closed jortilles closed 1 year ago

jortilles commented 1 year ago

Apache Hop version?

2.3

Java version?

oracle_jdk-11.0.16.1_windows-x64_bin

Operating system

Windows

What happened?

Filter rows is not getting the numbers as should be it does not get decimals properly.

1_to_10.zip

Issue Priority

Priority: 3

Issue Component

Component: Hop Gui

bamaer commented 1 year ago

the issue is that the filter rows transform doesn't store the value correctly, so it changes when you open the dialog again, right?

I tried to reproduce, but haven't been able to in 2.4.0-20230315 or 2.3.0: 2573.hpl.txt

jortilles commented 1 year ago

Yes. It happened to me in 2.3

El El mié, 15 mar 2023 a las 19:59, Bart Maertens @.***> escribió:

the issue is that the filter rows transform doesn't store the value correctly, so it changes when you open the dialog again, right?

I tried to reproduce, but haven't been able to in 2.4.0-20230315 or 2.3.0: 2573.hpl.txt https://github.com/apache/hop/files/10983646/2573.hpl.txt

— Reply to this email directly, view it on GitHub https://github.com/apache/hop/issues/2573#issuecomment-1470612438, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKHGNBLLKJYD347SNGKRVDW4IGPJANCNFSM6AAAAAAV36L5FQ . You are receiving this because you authored the thread.Message ID: @.***>

-- ------------------------------------------------------------------- Juanjo Ortilles Jortilles: Open https://www.jortilles.com/Business Analytics https://www.jortilles.com/ | EDA: the most friendly analytical tool https://eda.jortilles.com/ @. @.>ti @.>lles.com @.> Tlf: +34 664 720 760

Este correo electrónico y, en su caso, cualquier fichero anexo al mismo, contiene información de carácter confidencial exclusivamente dirigida a su destinatario o destinatarios. Queda prohibida su divulgación, copia o distribución a terceros sin la previa autorización escrita del remitente, en virtud de la legislación vigente. En el caso de haber recibido este correo electrónico por error, se ruega notificar inmediatamente esta circunstancia mediante reenvío a la dirección electrónica del remitente y la destrucción del mismo.

jortilles commented 1 year ago

Maybe it have some relation with the locale of the computer. In spanish the decimal separator is , instead of .

English: 1,000.00 Spanish: 1.000,00

El El mié, 15 mar 2023 a las 19:59, Bart Maertens @.***> escribió:

the issue is that the filter rows transform doesn't store the value correctly, so it changes when you open the dialog again, right?

I tried to reproduce, but haven't been able to in 2.4.0-20230315 or 2.3.0: 2573.hpl.txt https://github.com/apache/hop/files/10983646/2573.hpl.txt

— Reply to this email directly, view it on GitHub https://github.com/apache/hop/issues/2573#issuecomment-1470612438, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKHGNBLLKJYD347SNGKRVDW4IGPJANCNFSM6AAAAAAV36L5FQ . You are receiving this because you authored the thread.Message ID: @.***>

-- ------------------------------------------------------------------- Juanjo Ortilles Jortilles: Open https://www.jortilles.com/Business Analytics https://www.jortilles.com/ | EDA: the most friendly analytical tool https://eda.jortilles.com/ @. @.>ti @.>lles.com @.> Tlf: +34 664 720 760

Este correo electrónico y, en su caso, cualquier fichero anexo al mismo, contiene información de carácter confidencial exclusivamente dirigida a su destinatario o destinatarios. Queda prohibida su divulgación, copia o distribución a terceros sin la previa autorización escrita del remitente, en virtud de la legislación vigente. En el caso de haber recibido este correo electrónico por error, se ruega notificar inmediatamente esta circunstancia mediante reenvío a la dirección electrónica del remitente y la destrucción del mismo.

jortilles commented 1 year ago

I'm sure it is related with the spanish locale.

I've tested your htr in 2.3 and i still have the same issue:

2 3

This same happens with 2.4 image

hansva commented 1 year ago

.take-issue