apache / hop

Hop Orchestration Platform
https://hop.apache.org/
Apache License 2.0
978 stars 350 forks source link

[Feature Request]: Support Adoptium JVM #3604

Open seltner opened 9 months ago

seltner commented 9 months ago

What would you like to happen?

Do you plan to support Adoptium JVM from Eclipse Foundation in the future?

Asking cause of having trouble to see the hop-gui with the latest Temurin JRE with version 11.0.22+7 (hop-gui is working with 11.0.20,8) and we have to use Adoptium JVM as default.

Also have seen in your superb docs here that it is currently unsupported - https://hop.apache.org//manual/latest/supported-jvms.html

Issue Priority

Priority: 3

Issue Component

Component: Hop Gui

hansva commented 9 months ago

We are unsure what is causing the Adoptium/Temurin JVM issues. The page you are referring to was created after we received multiple reports of issues with this specific JVM.

As far as I know, the baseline for all these JVM's is the same (OpenJDK) so it was a big surprise to us that the UI does not load on Temurin (especially with the fact that we use SWT which is also an Eclipse project).

sramazzina commented 9 months ago

I'm using Temurin on Windows/Linux from the time being without any problem. Currently I'm on jdk 11.0.21+9. @seltner I will try the version you are suggesting and let you know

seltner commented 9 months ago

Hi @hansva , thx for the info - and also for me a good info that you crated that page after having problems with Adoptium/Temurin JVM and not the other way round that you already planned from the start to not support this specific JVM :rofl:

@sramazzina also thx for your info. i am currently working with macOS 14.3 (23D56)

java -version

openjdk version "11.0.22" 2024-01-16
OpenJDK Runtime Environment Temurin-11.0.22+7 (build 11.0.22+7)
OpenJDK 64-Bit Server VM Temurin-11.0.22+7 (build 11.0.22+7, mixed mode)

result:

Screenshot1
sramazzina commented 9 months ago

Windows 11 with Temurin JDK (the version that is failing on your side).

C:\java\hop\hop>echo off
===[Environment Settings - hop-gui.bat]===================================

Java identified as "C:\Program Files\Eclipse Adoptium\jdk-11.0.22.7-hotspot\bin\java"

HOP_OPTIONS=-Xmx2048m -DHOP_AUDIT_FOLDER=.\audit -DHOP_PLATFORM_OS=Windows -DHOP_PLATFORM_RUNTIME=GUI -DHOP_AUTO_CREATE_CONFIG=Y

Command to start Hop will be:
"C:\Program Files\Eclipse Adoptium\jdk-11.0.22.7-hotspot\bin\java" -classpath lib\core\*;lib\beam\*;lib\swt\win64\* -Djava.library.path=lib\core;lib\beam -Xmx2048m -DHOP_AUDIT_FOLDER=.\audit -DHOP_PLATFORM_OS=Windows -DHOP_PLATFORM_RUNTIME=GUI -DHOP_AUTO_CREATE_CONFIG=Y org.apache.hop.ui.hopgui.HopGui

===[Starting Hop]=========================================================
2024/02/05 10:42:51 - Hop - Projects enabled
2024/02/05 10:42:51 - Hop - Enabling project : 'default'

image

hansva commented 9 months ago

I can confirm it doesn't work with the latest version

openjdk version "11.0.22" 2024-01-16
OpenJDK Runtime Environment Temurin-11.0.22+7 (build 11.0.22+7)
OpenJDK 64-Bit Server VM Temurin-11.0.22+7 (build 11.0.22+7, mixed mode)

image

sramazzina commented 9 months ago

I think is a MacOS only issue unfortunately :-(

nadment commented 9 months ago

It's a MacOS only issue

https://github.com/eclipse-platform/eclipse.platform.swt/issues/1012

Phillipus commented 9 months ago

The problem you are seeing is caused by the fact that the latest Temurin JDKs for Mac are built using macOS SDK 14. The Oracle JDK is built using an earlier SDK. If Oracle and others ever build their Mac JDKs against macOS SDK 14 or later you'll see the same problem.

See https://github.com/eclipse-platform/eclipse.platform.swt/issues/1012#issuecomment-1915168980

hansva commented 7 months ago

It seems a fix has been applied to SWT to handle this problem. One small issue on our side... we are stuck on the current SWT version as the newer version requires us to start the Java upgrade. New SWT releases only work on java 17 and higher.