apache / hop

Hop Orchestration Platform
https://hop.apache.org/
Apache License 2.0
871 stars 326 forks source link

[Bug]: Workflow engine type "Hop remote workflow engine" can reference itself #3935

Closed dsanderbi closed 1 week ago

dsanderbi commented 2 weeks ago

Apache Hop version?

2.8.0

Java version?

openjdk version "11.0.23" 2024-04-16 LTS

Operating system

Windows

What happened?

Issue Description:

The workflow run configuration for workflow engine type "Hop remote workflow engine" can reference itself.

Incident Details:

This issue occurred with the following workflow:

Hop server is running on a VM (VirtualBox, Ubuntu 24.04, openjdk version "11.0.23" 2024-04-16), default installation with no modifications. In the Hop GUI (Windows), the server was added via the Metadata button -> Add Hop Server. The workflow run configuration "test" was created with "Hop remote workflow engine".

Clicking on the "Start execution button" then click on the play button. This opens the run configuration for "test". Here it is possible to select again "test" as run configuration. Clicking OK -> Launch results in the following error, see file: log.log

image

Resetting to local run configuration and starting the Workflow again -> pop-up indicates that the workflow is already running. However the stop button is greyed-out.

image Later, the stop button becomes visible, but clicking it does not abort the process. Restarting Hop is required to resume work.

Expected Behavior:

When opening the run options -> edit this metadata image it should not be possible to select "test" run configuration again!

Issue Priority

Priority: 2

Issue Component

Component: Hop Gui, Component: Hop Server, Component: Metadata, Component: Workflows

nadment commented 1 week ago

Same problem for pipeline remote run configuration which can refer to itself