search

apache / hop

Hop Orchestration Platform
https://hop.apache.org/
Apache License 2.0
985 stars 354 forks source link

[Bug]: Write to log (transform) - Unable to select specified fields to log #4577

Closed dave-csc closed 1 day ago

dave-csc commented 4 days ago

Apache Hop version?

2.10.0

Java version?

17.0.2

Operating system

Linux

What happened?

Add a Write to log transform in a pipeline.

In version 2.10.0, you cannot specify directly the fields you want to log, unless you press the button Get fields and then remove the unnecessary ones.

In version 2.9.0, you can choose the fields you want to log without workarounds.

Marked as P1 for regression

Issue Priority

Priority: 1

Issue Component

Component: Hop Gui, Component: Transforms

bamaer commented 3 days ago

.take-issue

shlxue commented 1 day ago

Maybe it should be updated itemCount in TableView.removeAll method.

hansva commented 1 day ago

I'll review both fixes because now we have 2 PR's for this issue.

shlxue commented 1 day ago

😄. When automatically appending an empty row as the default behavior of tableview: the tableview must keep the itemcount & count of TableItem consistent.

Normal:

  1. create tableview ui
  2. Init columns(sync or async)
  3. in getData method 3.1 remove all 3.2 append rows(if 0 row? --> itemcount is 0 --> non edit mode)
  4. SetRowNum(must be active edit mode if 0 row)
  5. optWidth