apache / hudi-rs

A native Rust library for Apache Hudi, with bindings into Python
https://hudi.apache.org/
Apache License 2.0
142 stars 28 forks source link

refactor: define Hudi error types across hudi-core #124

Open gohalo opened 1 month ago

gohalo commented 1 month ago

Description

Use thiserror instead of anyhow to define the error for hudi-core crate.

Currently, work in progress.

72

How are the changes test-covered

gohalo commented 1 month ago

@xushiyan @codope Hope this codes could be reviewed as soon as possible, because it refact the core crate, and almost every new merged code should refact again. 😊

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 71.30435% with 33 lines in your changes missing coverage. Please review.

Project coverage is 86.80%. Comparing base (01ef2fc) to head (fb6ff8e). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/table/mod.rs 33.33% 10 Missing :warning:
crates/core/src/storage/utils.rs 56.25% 7 Missing :warning:
crates/core/src/storage/mod.rs 78.94% 4 Missing :warning:
python/src/internal.rs 0.00% 4 Missing :warning:
crates/core/src/config/internal.rs 60.00% 2 Missing :warning:
crates/core/src/config/table.rs 93.54% 2 Missing :warning:
crates/core/src/file_group/mod.rs 71.42% 2 Missing :warning:
crates/core/src/table/fs_view.rs 0.00% 1 Missing :warning:
crates/core/src/table/timeline.rs 91.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #124 +/- ## ========================================== - Coverage 87.77% 86.80% -0.98% ========================================== Files 14 15 +1 Lines 728 773 +45 ========================================== + Hits 639 671 +32 - Misses 89 102 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.