apache / hudi-rs

A native Rust library for Apache Hudi, with bindings into Python
https://hudi.apache.org/
Apache License 2.0
142 stars 28 forks source link

Partition filter against string or date field should strip `'` around the value #165

Closed xushiyan closed 1 day ago

xushiyan commented 1 week ago

Is there an existing issue for this?

Description of the bug

Partition filter currently works for foo > A for string field. To match sql syntax, it should be foo > 'A'. But current logic won't trim the single quotes and take 'A' as a whole for the value. Similarly for date types, it should parse date = '2020-01-01' correctly.

Steps To Reproduce

Run with partition filters like foo > A for a string field, and date = '2020-01-01' for a date field.

Expected behavior

Single quotes should be stripped for applicable field types.

Screenshots / Logs

No response

Software information

Additional context

No response

xushiyan commented 1 week ago

hey @KnightChess do you happen to have some time to work on this issue? hope to get this in 0.2.0

KnightChess commented 1 week ago

@xushiyan hi, sorry, I've been quite busy these past few weeks and haven't had time to follow up on this issue.

xushiyan commented 1 week ago

@KnightChess no problem

kazdy commented 6 days ago

@xushiyan please take a look at #170 I took an attempt to fix this