apache / hudi

Upserts, Deletes And Incremental Processing on Big Data.
https://hudi.apache.org/
Apache License 2.0
5.46k stars 2.43k forks source link

[SUPPORT] Should we introduce partition-level metrics ? #12197

Open TheR1sing3un opened 3 weeks ago

TheR1sing3un commented 3 weeks ago

Can we provide partition-level metrics? In many scenarios where partitions are used, such as p_date and p_product, which are separated by time or type, the data before the partition is quite different. Can we provide a partition dimension metrics to reflect some metrics, for example, p99 latency of compaction operation for specified partition? This will help a lot when doing performance optimization.

Tips before filing an issue

Describe the problem you faced

A clear and concise description of the problem.

To Reproduce

Steps to reproduce the behavior:

1. 2. 3. 4.

Expected behavior

A clear and concise description of what you expected to happen.

Environment Description

Additional context

Add any other context about the problem here.

Stacktrace

Add the stacktrace of the error.

vinothchandar commented 3 weeks ago

Only downside is - users partitioning things too granular, leading to bombardment of metrics systems downstream..

I see how its useful though.

danny0405 commented 3 weeks ago

for example, p99 latency of compaction operation for specified partition

Is it feasible to extend the compaction metrics a little bit, maybe just represent the latecy metrics in another level: aggregated by partitions.

TheR1sing3un commented 3 weeks ago

Only downside is - users partitioning things too granular, leading to bombardment of metrics systems downstream..

Yes, we also need to consider the case of too many partitions, I think we can provide this ability, by the actual user to consider whether to turn on.

TheR1sing3un commented 3 weeks ago

for example, p99 latency of compaction operation for specified partition

Is it feasible to extend the compaction metrics a little bit, maybe just represent the latecy metrics in another level: aggregated by partitions.

I plan to provide a Histogram aggregated by partition. It will records compaction stats such as: