search

apache / iceberg-go

Apache Iceberg - Go
https://iceberg.apache.org/
Apache License 2.0
142 stars 34 forks source link

Impl rest catalog + table updates & requirements #146

Open jwtryg opened 2 months ago

jwtryg commented 2 months ago

Hi @zeroshade

I think it's really cool that you are working on a golang-iceberg implementation, and I would like to contribute if I can. I have tried to finish the rest catalog implementation, and then I have added table updates and requirements, using a new MetadataBuilder struct that can simplify updating metadata. Like the existing implementation, I have tried to stay close to the pyIceberg implementation.

I thought this could be a good starting point for also implementing transactions and table updates. I would love to get your input and change/adjust the implementation accordingly.

jwtryg commented 1 month ago

Hi @zeroshade

I sincerely apologise for not getting back to you sooner, I suddenly found myself with very little time on my hands. Once more, I thank you for your feedback - I will make sure to address all of your comments above this week!

zeroshade commented 1 month ago

@jwtryg any updates?

jwtryg commented 3 weeks ago

@zeroshade thank you for your patience :)

I have implemented your feedback and made some other changes - specifically, being more mindful of what should be exported, and then undoing the manic nil-pointer checking I somehow got myself into.