search

apache / iceberg-go

Apache Iceberg - Go
https://iceberg.apache.org/
Apache License 2.0
142 stars 34 forks source link

Fix `version` and `rc` in `rc.yml` #202

Closed kevinjqliu closed 1 week ago

kevinjqliu commented 1 week ago

Follow up to #199. For the RC workflow running on a tag, there was an issue resulting in the wrong filename used for the tar.gz file, for example, apache-iceberg-go-0.1.0-rc1-rc1.tar.gz. Notice the extra -rc.

This is due to the parsing logic which is fixed in this PR.

For details, see https://github.com/apache/iceberg-go/actions/runs/11821595808/job/32936689238 where the Archive job's Archive step has the following

  env:
    VERSION: 0.1.0-rc1
    RC: 1

Tested in fork repo. v0.1.0-rc1 release https://github.com/kevinjqliu/iceberg-go/releases/tag/v0.1.0-rc1 https://github.com/kevinjqliu/iceberg-go/actions/runs/11824564368/job/32946341965 Downloaded artifacts in https://github.com/kevinjqliu/iceberg-go/actions/runs/11824501122 and checked the sha256 file is correct

RussellSpitzer commented 1 week ago

Thanks @kevinjqliu for the PR and @zeroshade for reviewing!