search

apache / iceberg-go

Apache Iceberg - Go
https://iceberg.apache.org/
Apache License 2.0
143 stars 35 forks source link

Manifest builder length #69

Closed thorfour closed 8 months ago

thorfour commented 8 months ago

Question

How is one intended to get the length of the manifest file when building the file? Seems like the builder should be the one able to generate the length after calling Build()?

https://github.com/apache/iceberg-go/blob/5db83a0d711481ef798c90ae1ad89076db743082/manifest.go#L56

thorfour commented 8 months ago

Ah I realize now that I was confused by the comment on the ManifestFile interface

      // Length is the length in bytes of the manifest file.

Whereas its the length of the manifest entries file. Naming was confusing. Sorry about the question..