search

apache / iceberg-go

Apache Iceberg - Go
https://iceberg.apache.org/
Apache License 2.0
143 stars 35 forks source link

feat: Adding literals #76

Closed zeroshade closed 6 months ago

zeroshade commented 6 months ago

After about 5 or 6 iterations of playing with how to represent expressions to start working on scan planning, I've finally settled on something I like!!

Rather than a huge code dump, I've broken it out into smaller successive PRs so that it is easier to review. This PR contains the definitions for representing Literals, which will then get utilized in constructing BooleanExpressions and so on.

zeroshade commented 6 months ago

CC @Fokko @nastra @wolfeidau

wolfeidau commented 6 months ago

@zeroshade this is a considerable amount of work, I really need to learn more about the internals of iceberg, mostly working to understand the metadata.

Looks great, nothing stands out as issues to me.

Fokko commented 6 months ago

@zeroshade Thanks! Can you fix the conflicts?

zeroshade commented 6 months ago

updated and fixed the conflicts @Fokko! :smile:

Fokko commented 6 months ago

@zeroshade Awesome, let's get this in! 🚀