Remove `InMemoryCatalog` from the test-codebase

apache / iceberg-python

Apache PyIceberg

https://py.iceberg.apache.org/

Apache License 2.0

402 stars 147 forks source link

Remove `InMemoryCatalog` from the test-codebase #1110

Open Fokko opened 1 month ago

Fokko commented 1 month ago

Feature Request / Improvement

InMemoryCatalog can be replaced by the SqlCatalog with Sqlite as a backend. Less code is more :)

kevinjqliu commented 4 weeks ago

perhaps its a good idea to alias a new InMemoryCatalog implementation using SqlCatalog such as https://github.com/apache/iceberg-python/blob/9857107561d2267813b7ce150b01b4e6ac4b3e34/tests/catalog/test_sql.py#L113-L117

hussein-awala commented 3 weeks ago

@Fokko I agree with @kevinjqliu on the alias proposition, I implemented https://github.com/apache/iceberg-python/pull/1140 which makes InMemoryCatalog a subclass of SqlCatalog, and overrides some methods to simplify the tests.