search

apache / iceberg-python

Apache PyIceberg
https://py.iceberg.apache.org/
Apache License 2.0
446 stars 162 forks source link

`project_table` is deprecated, remove references #1119

Closed kevinjqliu closed 1 month ago

kevinjqliu commented 2 months ago

Feature Request / Improvement

project_table is still used in the codebase, leading to deprecation warning

https://github.com/apache/iceberg-python/blob/e4c1748fee220076f04e35ab2f182dd51ca20705/pyiceberg/io/pyarrow.py#L1493-L1498

Remove all references https://github.com/search?q=repo%3Aapache%2Ficeberg-python%20project_table&type=code

and use ArrowScan.to_table instead

souravsingh commented 2 months ago

Hello, I am interested in working on this.

kevinjqliu commented 2 months ago

sounds good, assigned to you

JE-Chen commented 1 month ago

I can’t replace all project_table using ArrowScan.to_table because ArrowScan.to_table is not a @staticmethod (need ArrowScan instance).

kevinjqliu commented 1 month ago

@JE-Chen You can create an ArrowScan instance like so https://github.com/apache/iceberg-python/blob/0dc54080aa287dc8e920da128d7f4b335965f1df/pyiceberg/table/__init__.py#L1398-L1403

The args should be the same as project_table

kevinjqliu commented 1 month ago

Closed by #1180