search

apache / iceberg-python

Apache PyIceberg
https://py.iceberg.apache.org/
Apache License 2.0
402 stars 147 forks source link

fix: Invert `case_sensitive` logic in StructType #1147

Closed AnthonyLam closed 3 weeks ago

AnthonyLam commented 3 weeks ago

The field_by_name method in StructType seems to have inverted logic on the case_sensitive parameter.

ndrluis commented 3 weeks ago

Hello @AnthonyLam, thank you for your contribution. Could you add a test to ensure the expected behavior?

AnthonyLam commented 3 weeks ago

Hello @AnthonyLam, thank you for your contribution. Could you add a test to ensure the expected behavior?

For sure! I've added a test in test_types.py. Let me know if it's insufficient.

sungwy commented 3 weeks ago

Hi @AnthonyLam thank you for working on this PR and @ndrluis , @kevinjqliu thank you for the review! I've triggered the CI, and it looks like there's a few issues with the test. Once those are resolved, I'm happy to do another round of review