search

apache / iceberg-python

Apache PyIceberg
https://py.iceberg.apache.org/
Apache License 2.0
472 stars 174 forks source link

Document table properties #1231

Open kevinjqliu opened 1 month ago

kevinjqliu commented 1 month ago

Feature Request / Improvement

While debugging, we noticed that certain table properties are not documented in the configurations page

Such as write.target-file-size-bytes https://github.com/apache/iceberg-python/blob/7cf0c225c3cdb32ac5e390de06b7b0e4fe7de92e/pyiceberg/io/pyarrow.py#L2604-L2608 https://github.com/apache/iceberg-python/blob/7cf0c225c3cdb32ac5e390de06b7b0e4fe7de92e/pyiceberg/table/__init__.py#L177-L178

We should go through all the table properties and make sure they are properly documented

sikehish commented 1 month ago

I'd love to take this up! Could you assign this to me?

kevinjqliu commented 1 month ago

@sikehish assigned!

sikehish commented 1 month ago

@sikehish assigned!

Thank you, I'm working on it.

sikehish commented 1 month ago

@kevinjqliu
Hi, I've created a PR #1232 . Let me know if any changes are to be made. Thank you for the oppurtunity :)